pitrou commented on code in PR #41971: URL: https://github.com/apache/arrow/pull/41971#discussion_r1629406589
########## cpp/src/arrow/type_fwd.h: ########## @@ -525,19 +525,19 @@ std::shared_ptr<DataType> decimal256(int32_t precision, int32_t scale); /// \brief Create a ListType instance from its child Field type ARROW_EXPORT -std::shared_ptr<DataType> list(const std::shared_ptr<Field>& value_type); +std::shared_ptr<DataType> list(std::shared_ptr<Field> value_type); Review Comment: We've already made such changes in the past and nobody complained. This doesn't morally change the API (any existing usage should still work properly) and we don't make any promises about the ABI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
