AlenkaF commented on PR #41889:
URL: https://github.com/apache/arrow/pull/41889#issuecomment-2152430000
> Some more suggestions for the tests:
>
> * test the repr
> * does the `equals()` method work? (both for cuda == cuda or cuda == cpu)
I have added all together with the other suggestions.
> * pickling might also segfault?
It doesn't look it segfaults. I get this error though:
```python
> result = pickle_module.loads(pickle_module.dumps(buf_on_gpu))
pyarrow/tests/test_io.py:692:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
../../envs/arrow-dev/lib/python3.11/site-packages/cloudpickle/cloudpickle.py:1479:
in dumps
cp.dump(obj)
../../envs/arrow-dev/lib/python3.11/site-packages/cloudpickle/cloudpickle.py:1245:
in dump
return super().dump(obj)
pyarrow/io.pxi:1413: in pyarrow.lib.Buffer.__reduce_ex__
bufobj = pickle.PickleBuffer(self)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> assert buffer.len == 0
E AssertionError
pyarrow/io.pxi:1444: AssertionError
```
Haven't looked into it yet. Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
