domoritz commented on code in PR #41965:
URL: https://github.com/apache/arrow/pull/41965#discussion_r1630252199
##########
js/src/ipc/writer.ts:
##########
@@ -294,9 +294,9 @@ export class RecordBatchWriter<T extends TypeMap = any>
extends ReadableInterop<
if (!prevDictionary || prevDictionary.data[0] !== chunks[0]) {
// * If `index > 0`, then `isDelta` is true.
// * If `index = 0`, then `isDelta` is false, because this is
either the initial or a replacement DictionaryMessage.
- chunks.forEach((chunk, index) =>
this._writeDictionaryBatch(chunk, id, index > 0));
+ for (const [index, chunk] of chunks.entries())
this._writeDictionaryBatch(chunk, id, index > 0);
Review Comment:
You can disable it for the line/file only as a compromise. Unless the perf
difference is too small to matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
