alamb commented on code in PR #5848:
URL: https://github.com/apache/arrow-rs/pull/5848#discussion_r1630282804
##########
parquet/src/arrow/arrow_reader/selection.rs:
##########
@@ -111,13 +118,13 @@ impl RowSelection {
SlicesIterator::new(filter).map(move |(start, end)| start +
offset..end + offset)
});
- Self::from_consecutive_ranges(iter, total_rows)
+ Self::from_consecutive_ranges(iter, Some(total_rows))
}
/// Creates a [`RowSelection`] from an iterator of consecutive ranges to
keep
- pub(crate) fn from_consecutive_ranges<I: Iterator<Item = Range<usize>>>(
+ pub fn from_consecutive_ranges<I: Iterator<Item = Range<usize>>>(
ranges: I,
- total_rows: usize,
+ total_rows_opt: Option<usize>,
Review Comment:
> I see, I thought the final skip is optional based on the trim function.
It probably didn't help that several test cases in
https://github.com/apache/datafusion/pull/10738 didn't do this correctly
either. I have fixed them in https://github.com/apache/datafusion/pull/10813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
