felipecrv commented on PR #507: URL: https://github.com/apache/arrow-nanoarrow/pull/507#issuecomment-2155325414
> Just a few nits, but this looks good from my end! > > @felipecrv are there any more REE-specific details relevant to this PR (or follow-ups that we need to open issues for and tackle before the next release?) Not that I'm aware right now. I recommend that you and @cocoa-xu take a look at the C++ code around REEs to see all the traps. I don't remember everything that I did, but I left many comments in the C++ implementation. https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/ree_util.h and https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/ree_util.cc are good sources to look at. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
