joemarshall commented on code in PR #37822:
URL: https://github.com/apache/arrow/pull/37822#discussion_r1633244752
##########
python/setup.py:
##########
@@ -40,6 +40,12 @@
# Check if we're running 64-bit Python
is_64_bit = sys.maxsize > 2**32
+is_emscripten = (
+ sysconfig.get_config_var("SOABI")
+ and sysconfig.get_config_var("SOABI").find("emscripten") != -1
+)
Review Comment:
Yes, because in cross-compiling situations it appears `sys.platform`
contains the build platform (i.e. linux / windows or whatever), whereas
`sysconfig` contains the target platform (i.e. emscripten). So in setup.py,
which is running on a host platform, you have to look as `sysconfig`, whereas
in code that will actually run on emscripten, you can use sys.platform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
