paleolimbot opened a new pull request, #514: URL: https://github.com/apache/arrow-nanoarrow/pull/514
Tests for https://github.com/apache/arrow-nanoarrow/pull/507 and https://github.com/apache/arrow-nanoarrow/pull/501 and/or https://github.com/apache/arrow-nanoarrow/pull/503 either used C++17 or features from Arrow C++ > 12. Our test suite still supports these (although perhaps parts of this support should be dropped soon). On Windows, formatting with `%lu` was doing some unexpected formatting. We could do a better job formatting 64-bit integers in error messages (e.g., using `PRId64` and the requisite defines to ensure it works on mingw); however, we probably won't ever be able to support properly formatting an unsigned 64-bit integer on every platform we support. I changed the error message (and its test) slightly to reflect that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
