laurentgo commented on code in PR #42062:
URL: https://github.com/apache/arrow/pull/42062#discussion_r1633402283
##########
java/dataset/src/main/java/org/apache/arrow/dataset/jni/DirectReservationListener.java:
##########
@@ -40,10 +38,13 @@ private DirectReservationListener() {
methodUnreserve = this.getDeclaredMethodBaseOnJDKVersion(classBits,
"unreserveMemory");
methodUnreserve.setAccessible(true);
} catch (Exception e) {
- final RuntimeException failure = new RuntimeException(
- "Failed to initialize DirectReservationListener. When starting Java
you must include " +
-
"`--add-opens=java.base/java.nio=org.apache.arrow.dataset,org.apache.arrow.memory.core,ALL-UNNAMED`
" +
- "(See https://arrow.apache.org/docs/java/install.html)", e);
+ final RuntimeException failure =
+ new RuntimeException(
+ "Failed to initialize DirectReservationListener. When starting
Java you must include "
+ + "`--add-opens=java.base/java.nio=org.apache.arrow.dataset,"
+ + "org.apache.arrow.memory.core,ALL-UNNAMED` "
+ + "(See https://arrow.apache.org/docs/java/install.html)",
+ e);
Review Comment:
I actually removed the checkstyle limitation in one of my changes since
g-j-f does not wrap if the string constant is slightly longer. See
https://github.com/apache/arrow/pull/42056/files#diff-11c4c82ba6105f982f448e61144c0055b27cb60a8f8b590e83785530c8f78ff7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
