ryan-syed commented on code in PR #1911:
URL: https://github.com/apache/arrow-adbc/pull/1911#discussion_r1633678512
##########
csharp/src/Drivers/Apache/Spark/SparkConnection.cs:
##########
@@ -719,28 +719,31 @@ private static void SetPrecisionScaleAndTypeName(short
colType, string typeName,
case (short)ColumnTypeId.NCHAR:
{
bool success = new
SqlCharTypeParser().TryParse(typeName, out SqlCharVarcharParserResult? result);
- tableInfo?.Precision.Add(success ? result!.ColumnSize
: SqlVarcharTypeParser.VarcharColumnSizeDefault);
+ tableInfo?.Precision.Add(success && result != null ?
result.ColumnSize : SqlVarcharTypeParser.VarcharColumnSizeDefault);
tableInfo?.Scale.Add(null);
- tableInfo?.BaseTypeName.Add(success ?
result!.BaseTypeName : "CHAR");
+ tableInfo?.BaseTypeName.Add(success && result != null
? result.BaseTypeName : "CHAR");
break;
}
+
case (short)ColumnTypeId.VARCHAR:
case (short)ColumnTypeId.LONGVARCHAR:
case (short)ColumnTypeId.LONGNVARCHAR:
case (short)ColumnTypeId.NVARCHAR:
{
bool success = new
SqlVarcharTypeParser().TryParse(typeName, out SqlCharVarcharParserResult?
result);
- tableInfo?.Precision.Add(success ? result!.ColumnSize
: SqlVarcharTypeParser.VarcharColumnSizeDefault);
+ tableInfo?.Precision.Add(success && result != null ?
result.ColumnSize : SqlVarcharTypeParser.VarcharColumnSizeDefault);
Review Comment:
result seems to be nullable type, we could use null-coalescing operator to
make this concise
```suggestion
tableInfo?.Precision.Add(success &&
result?.ColumnSize ?? SqlVarcharTypeParser.VarcharColumnSizeDefault);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
