xinlifoobar commented on PR #5868: URL: https://github.com/apache/arrow-rs/pull/5868#issuecomment-2159942189
This PR is super weird due to: 1. From a spec perspective, it defines the interval data type as 12 bytes which could not accommodate the IntervalMonthDayNanoArray(16 bytes). 2. From the `arrow-rs` implementations, the interval type is not defined as a logic type. https://github.com/apache/arrow-rs/blob/76d04a8fa48c92185cb3681c906cdd6e06dca391/parquet/src/basic.rs#L171-L198 It would be more natural if we set both logic type and converted type at https://github.com/apache/arrow-rs/blob/76d04a8fa48c92185cb3681c906cdd6e06dca391/parquet/src/schema/types.rs#L191-L201 Now it is (None, ConvertedType:Interval). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
