nbruno commented on a change in pull request #9151:
URL: https://github.com/apache/arrow/pull/9151#discussion_r583064206
##########
File path: java/vector/src/main/codegen/templates/UnionFixedSizeListWriter.java
##########
@@ -169,6 +169,29 @@ public StructWriter struct(String name) {
return structWriter;
}
+ @Override
+ public MapWriter map() {
+ return writer;
+ }
+
+ @Override
+ public MapWriter map(String name) {
+ MapWriter mapWriter = writer.map(name);
+ return mapWriter;
+ }
+
+ @Override
+ public MapWriter map(boolean keysSorted) {
+ writer.map(keysSorted);
Review comment:
I tried digging into this a little bit more and stepped through what is
done for list. I think? we are matching what is done for list, for example [see
here](https://github.com/apache/arrow/blob/master/java/vector/src/main/codegen/templates/UnionListWriter.java#L162)
where `list()` just returns the current `UnionListWriter`. Since we need
`keysSorted` for map, there's an additional `map(boolean)` method, but just
like `map()` we return the current writer. Appreciate any more insight you can
provide here Bryan.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
