jhorstmann opened a new pull request, #5869: URL: https://github.com/apache/arrow-rs/pull/5869
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes #5854, part of the investigation in #5770. # Rationale for this change This integrates the custom thrift parser mentioned in #5854 into the arrow-rs codebase. The intent is not to merge this as is, but to get feedback and let others run benchmarks on their datasets. The big open question is the maintainability of a custom code generator. <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> # What changes are included in this PR? The PR is based on the borrowing/Cow changes from @tustvold in #5777 The runtime library and parquet format code are not yet published to crates.io, their source code can be found at https://github.com/jhorstmann/compact-thrift/tree/main/src/main/rust There seems to be an open issue with reading page headers, probably related to the tracking of read bytes, which I still have to investigate. A flamegraph of the metadata benchmark shows that now about half of the time is spent in thrift parsing and the other half in converting the thrift structure to the  <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> # Are there any user-facing changes? The custom generator currently uses the exact names from the thrift specification, which differ in some cases from the previous names. For example `r#type` instead of `type` <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!--- If there are any breaking changes to public APIs, please add the `breaking change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
