adamreeve commented on code in PR #41886:
URL: https://github.com/apache/arrow/pull/41886#discussion_r1634520352
##########
csharp/glib_generated_fixes.patch:
##########
@@ -0,0 +1,2285 @@
+diff --git
a/csharp/src/Apache.Arrow.Dataset.GLibBindings-1.0/Public/DatasetFactory.Methods.Generated.cs
b/csharp/src/Apache.Arrow.Dataset.GLibBindings-1.0/Public/DatasetFactory.Methods.Generated.cs
+index dfaac7a27..6068d4530 100644
+---
a/csharp/src/Apache.Arrow.Dataset.GLibBindings-1.0/Public/DatasetFactory.Methods.Generated.cs
++++
b/csharp/src/Apache.Arrow.Dataset.GLibBindings-1.0/Public/DatasetFactory.Methods.Generated.cs
+@@ -14,7 +14,7 @@ public partial class DatasetFactory
+ {
+
+ [Version("5.0.0")]
+-public Apache.Arrow.Dataset.GLibBindings.Dataset?
Finish(Apache.Arrow.Dataset.GLibBindings.FinishOptions? options)
++public virtual Apache.Arrow.Dataset.GLibBindings.Dataset?
Finish(Apache.Arrow.Dataset.GLibBindings.FinishOptions? options)
+ {
+
+ var resultFinish =
Apache.Arrow.Dataset.GLibBindings.Internal.DatasetFactory.Finish(this.Handle,
options?.Handle ?? IntPtr.Zero, out GLib.Internal.ErrorOwnedHandle error);
+diff --git
a/csharp/src/Apache.Arrow.Dataset.GLibBindings-1.0/Public/FileSystemDatasetFactory.Methods.Generated.cs
b/csharp/src/Apache.Arrow.Dataset.GLibBindings-1.0/Public/FileSystemDatasetFactory.Methods.Generated.cs
+index 809181969..6c0c5855a 100644
+---
a/csharp/src/Apache.Arrow.Dataset.GLibBindings-1.0/Public/FileSystemDatasetFactory.Methods.Generated.cs
++++
b/csharp/src/Apache.Arrow.Dataset.GLibBindings-1.0/Public/FileSystemDatasetFactory.Methods.Generated.cs
+@@ -25,7 +25,7 @@ if(!error.IsInvalid)
+ }
+
+ [Version("5.0.0")]
+-public Apache.Arrow.Dataset.GLibBindings.FileSystemDataset?
Finish(Apache.Arrow.Dataset.GLibBindings.FinishOptions? options)
++public override Apache.Arrow.Dataset.GLibBindings.FileSystemDataset?
Finish(Apache.Arrow.Dataset.GLibBindings.FinishOptions? options)
+ {
+
+ var resultFinish =
Apache.Arrow.Dataset.GLibBindings.Internal.FileSystemDatasetFactory.Finish(this.Handle,
options?.Handle ?? IntPtr.Zero, out GLib.Internal.ErrorOwnedHandle error);
+diff --git
a/csharp/src/Apache.Arrow.GLibBindings-1.0/Public/AggregateNodeOptions.Constructors.Generated.cs
b/csharp/src/Apache.Arrow.GLibBindings-1.0/Public/AggregateNodeOptions.Constructors.Generated.cs
+index 313ec0ef1..caa4d5ab6 100644
+---
a/csharp/src/Apache.Arrow.GLibBindings-1.0/Public/AggregateNodeOptions.Constructors.Generated.cs
++++
b/csharp/src/Apache.Arrow.GLibBindings-1.0/Public/AggregateNodeOptions.Constructors.Generated.cs
+@@ -16,10 +16,14 @@ public partial class AggregateNodeOptions
+ [Version("6.0.0")]
+ public static AggregateNodeOptions? New(GLib.List aggregations, string[]?
keys, nuint nKeys)
+ {
+-
++
++ if (keys == null)
++ {
++ throw new ArgumentNullException(nameof(keys));
++ }
Review Comment:
I've opened https://github.com/gircore/gir.core/issues/1077 for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
