tustvold commented on code in PR #5858:
URL: https://github.com/apache/arrow-rs/pull/5858#discussion_r1634814827
##########
arrow-row/src/lib.rs:
##########
@@ -1146,9 +1146,21 @@ fn encode_column(
match encoder {
Encoder::Stateless => {
downcast_primitive_array! {
- column => fixed::encode(data, offsets, column, opts),
+ column => {
+ if column.is_nullable(){
Review Comment:
Typically we use `column.nulls().filter(|n| n.null_count() > 0)` or similar
for switching on nullability, this allows getting the benefit if there are no
nulls regardless of schema, but happy for this to be done as a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
