tustvold commented on PR #5835: URL: https://github.com/apache/arrow-rs/pull/5835#issuecomment-2160695396
Hi apologies I have been ill the last few days, looking again at this I think we could simply achieve this by adding `BufWriter::put` with the same signature as `BufUploader::put`. In my mind this would have a few key benefits: * Would avoid additional cognitive overhead for users wondering which abstraction to use * Is consistent with `WriteMultipart` which has both `write` and `put` methods * Allows mixing the `write` and `put` APIs, e.g. use `write` for thrift encoding and `put` for writing parquet pages * Already supports all the attributes, tags, etc... #5867 * Avoids code duplication What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
