jorisvandenbossche commented on PR #42034: URL: https://github.com/apache/arrow/pull/42034#issuecomment-2160771023
> Instead of doing such adjustements one by one, how about we vendor a version of https://github.com/python/pythoncapi-compat ? I am not very familiar with it to estimate how much we would make use of it (this PR also essentially only adds 3 lines, and the actual changes to change `_Py_IsFinalizing` to `Py_IsFinalizing` is still something that we would had to do). But yes, if that tool is exactly meant for this, maybe why not just use it. I quickly tested its upgrade script on the pyarrow C++ code, and what it does change is replace a bunch of `.. == Py_None` cases with `Py_IsNone(..)`. But maybe the more interesting usage of the tool would be that we can use newer C API functions in our code that might make our PyArrow C++ easier to read or maintain? (but again not sure how much of those cases would actually apply here) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
