pitrou commented on code in PR #41981:
URL: https://github.com/apache/arrow/pull/41981#discussion_r1635146307


##########
cpp/src/parquet/reader_test.cc:
##########
@@ -1077,7 +1077,24 @@ Column 1
   ASSERT_EQ(header_output + dump_output, ss_dump.str());
 }
 
-TEST(TestJSONWithLocalFile, JSONOutput) {
+class TestJSONWithLocalFile : public ::testing::Test {
+ public:
+  static std::string readFromLocalFile(std::string_view localFileName) {

Review Comment:
   Nit: coding style
   ```suggestion
     static std::string ReadFromLocalFile(std::string_view file_path) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to