felipecrv commented on code in PR #42067: URL: https://github.com/apache/arrow/pull/42067#discussion_r1635572132
########## cpp/src/arrow/compute/kernels/scalar_list_benchmark.cc: ########## @@ -0,0 +1,160 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <memory> +#include <type_traits> +#include <vector> + +#include "arrow/compute/api_scalar.h" +#include "arrow/compute/exec.h" +#include "arrow/testing/gtest_util.h" +#include "arrow/testing/random.h" +#include "arrow/util/benchmark_util.h" +#include "benchmark/benchmark.h" + +namespace arrow::compute { + +constexpr auto kSeed = 0x94378165; + +const auto kSliceStart = 2; +const auto kSliceStop = 10; + +template <typename InListType, typename ValueType, int32_t kFixedListSize = 0> Review Comment: `kFixedListSize` is completely unnecessary and I didn't mean to have it be `0` on every case 🤦. I will change the other two to normal `shared_ptr<DataType>` parameters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
