lidavidm commented on code in PR #42115:
URL: https://github.com/apache/arrow/pull/42115#discussion_r1635839465
##########
java/tools/src/test/java/org/apache/arrow/tools/TestFileRoundtrip.java:
##########
@@ -58,4 +61,36 @@ public void test() throws Exception {
validateOutput(testOutFile, allocator);
}
+
+ @Test
+ public void testDiffFolder() throws Exception {
+ File testInFile = testFolder.newFile("testIn.arrow");
+ File testOutFile = testAnotherFolder.newFile("testOut.arrow");
+
+ writeInput(testInFile, allocator);
+
+ String[] args = {"-i", testInFile.getAbsolutePath(), "-o",
testOutFile.getAbsolutePath()};
+ int result = new FileRoundtrip(System.err).run(args);
+ assertEquals(0, result);
+
+ validateOutput(testOutFile, allocator);
+ }
+
+ @Test
+ public void testNotPreparedInput() throws Exception {
+ File testInFile = testFolder.newFile("testIn.arrow");
+ File testOutFile = testFolder.newFile("testOut.arrow");
+
+ String[] args = {"-i", testInFile.getAbsolutePath(), "-o",
testOutFile.getAbsolutePath()};
+
+ // In JUnit 5, since the file itself is not created, the exception and
message will be
+ // different.
+ Exception exception =
+ assertThrows(
+ InvalidArrowFileException.class,
+ () -> {
+ new FileRoundtrip(System.err).run(args);
+ });
+ assertEquals("file too small: 0", exception.getMessage());
Review Comment:
What is actually being tested here? A 0-length input file?
##########
java/tools/src/main/java/org/apache/arrow/tools/FileRoundtrip.java:
##########
@@ -52,13 +52,29 @@ public static void main(String[] args) {
System.exit(new FileRoundtrip(System.err).run(args));
}
- private File validateFile(String type, String fileName) {
+ private File validateFile(String type, String fileName) throws IOException {
if (fileName == null) {
throw new IllegalArgumentException("missing " + type + " file
parameter");
}
File f = new File(fileName);
- if (!f.exists() || f.isDirectory()) {
- throw new IllegalArgumentException(type + " file not found: " +
f.getAbsolutePath());
+ if (type.equals("input")) {
+ if (!f.exists() || f.isDirectory()) {
+ throw new IllegalArgumentException(type + " file not found: " +
f.getAbsolutePath());
+ }
+ } else if (type.equals("output")) {
+ File parentDir = f.getParentFile();
+ if (parentDir != null && !parentDir.exists()) {
+ if (!parentDir.mkdirs()) {
+ throw new IOException(
+ "Failed to create parent directory: " +
parentDir.getAbsolutePath());
+ }
+ }
+ if (!f.exists()) {
Review Comment:
Hmm, why does the output _file_ need to exist?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
