h-vetinari commented on issue #41990:
URL: https://github.com/apache/arrow/issues/41990#issuecomment-2163019521
Thanks for the patch! It leads to:
```
[51/182] Building CXX object
src\arrow\CMakeFiles\arrow_compute_shared.dir\compute\kernels\aggregate_basic_avx512.cc.obj
[52/182] Building CXX object
src\arrow\CMakeFiles\arrow_filesystem_shared.dir\Unity\unity_0_cxx.cxx.obj
FAILED:
src/arrow/CMakeFiles/arrow_filesystem_shared.dir/Unity/unity_0_cxx.cxx.obj
C:\PROGRA~1\MICROS~2\2022\ENTERP~1\VC\Tools\MSVC\1429~1.301\bin\HostX64\x64\cl.exe
/nologo /TP -DABSL_CONSUME_DLL -DARROW_EXPORTING -DARROW_HAVE_RUNTIME_AVX2
-DARROW_HAVE_RUNTIME_AVX512 -DARROW_HAVE_RUNTIME_BMI2
-DARROW_HAVE_RUNTIME_SSE4_2 -DARROW_WITH_TIMING_TESTS
-DAWS_AUTH_USE_IMPORT_EXPORT -DAWS_CAL_USE_IMPORT_EXPORT
-DAWS_CHECKSUMS_USE_IMPORT_EXPORT -DAWS_COMMON_USE_IMPORT_EXPORT
-DAWS_COMPRESSION_USE_IMPORT_EXPORT -DAWS_CRT_CPP_USE_IMPORT_EXPORT
-DAWS_EVENT_STREAM_USE_IMPORT_EXPORT -DAWS_HTTP_USE_IMPORT_EXPORT
-DAWS_IO_USE_IMPORT_EXPORT -DAWS_MQTT_USE_IMPORT_EXPORT
-DAWS_S3_USE_IMPORT_EXPORT -DAWS_SDKUTILS_USE_IMPORT_EXPORT
-DAWS_SDK_VERSION_MAJOR=1 -DAWS_SDK_VERSION_MINOR=11
-DAWS_SDK_VERSION_PATCH=329 -DAWS_USE_IO_COMPLETION_PORTS -DAZ_CORE_DLL
-DAZ_IDENTITY_DLL -DAZ_RTTI -DAZ_STORAGE_BLOBS_DLL -DAZ_STORAGE_COMMON_DLL
-DAZ_STORAGE_FILES_DATALAKE_DLL -DPROTOBUF_USE_DLLS -DUSE_IMPORT_EXPORT
-DUSE_IMPORT_EXPORT=1 -DUSE_WINDOWS_DLL_SEMANTICS -D_CRT_SECURE_NO_WARNINGS
-D_ENABL
E_EXTENDED_ALIGNED_STORAGE -I%SRC_DIR%\cpp\build\src -I%SRC_DIR%\cpp\src
-I%SRC_DIR%\cpp\src\generated -external:I%PREFIX%\Library\include
-external:I%SRC_DIR%\cpp\thirdparty\hadoop\include -external:W0 /DWIN32
/D_WINDOWS /GR /EHsc /D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING /EHsc
/wd5105 /bigobj /utf-8 /W3 /wd4800 /wd4996 /wd4065 /O2 /Ob2 /DNDEBUG
-std:c++17 -MD /showIncludes
/Fosrc\arrow\CMakeFiles\arrow_filesystem_shared.dir\Unity\unity_0_cxx.cxx.obj
/Fdsrc\arrow\CMakeFiles\arrow_filesystem_shared.dir\ /FS -c
%SRC_DIR%\cpp\build\src\arrow\CMakeFiles\arrow_filesystem_shared.dir\Unity\unity_0_cxx.cxx
C:\Program Files\Microsoft Visual
Studio\2022\Enterprise\VC\Tools\MSVC\14.29.30133\include\memory(3089): error
C2027: use of undefined type 'arrow::fs::AzureFileSystem::Impl'
%SRC_DIR%\cpp\src\arrow/filesystem/azurefs.h(232): note: see declaration of
'arrow::fs::AzureFileSystem::Impl'
C:\Program Files\Microsoft Visual
Studio\2022\Enterprise\VC\Tools\MSVC\14.29.30133\include\memory(3088): note:
while compiling class template member function 'void
std::default_delete<arrow::fs::AzureFileSystem::Impl>::operator ()(_Ty *)
noexcept const'
with
[
_Ty=arrow::fs::AzureFileSystem::Impl
]
C:\Program Files\Microsoft Visual
Studio\2022\Enterprise\VC\Tools\MSVC\14.29.30133\include\memory(3198): note:
see reference to function template instantiation 'void
std::default_delete<arrow::fs::AzureFileSystem::Impl>::operator ()(_Ty *)
noexcept const' being compiled
with
[
_Ty=arrow::fs::AzureFileSystem::Impl
]
C:\Program Files\Microsoft Visual
Studio\2022\Enterprise\VC\Tools\MSVC\14.29.30133\include\memory(3125): note:
see reference to class template instantiation
'std::default_delete<arrow::fs::AzureFileSystem::Impl>' being compiled
%SRC_DIR%\cpp\src\arrow/filesystem/azurefs.h(233): note: see reference to
class template instantiation
'std::unique_ptr<arrow::fs::AzureFileSystem::Impl,std::default_delete<arrow::fs::AzureFileSystem::Impl>>'
being compiled
C:\Program Files\Microsoft Visual
Studio\2022\Enterprise\VC\Tools\MSVC\14.29.30133\include\memory(3089): error
C2338: can't delete an incomplete type
C:\Program Files\Microsoft Visual
Studio\2022\Enterprise\VC\Tools\MSVC\14.29.30133\include\memory(3090): warning
C4150: deletion of pointer to incomplete type
'arrow::fs::AzureFileSystem::Impl'; no destructor called
%SRC_DIR%\cpp\src\arrow/filesystem/azurefs.h(232): note: see declaration of
'arrow::fs::AzureFileSystem::Impl'
[53/182] Building CXX object
src\arrow\CMakeFiles\arrow_compute_shared.dir\compute\kernels\aggregate_basic_avx2.cc.obj
[54/182] Building CXX object
src\arrow\CMakeFiles\arrow_filesystem_shared.dir\filesystem\azurefs.cc.obj
%SRC_DIR%\cpp\src\arrow\filesystem\azurefs.cc(1093): warning C4101:
'exception': unreferenced local variable
%SRC_DIR%\cpp\src\arrow\filesystem\azurefs.cc(2188): warning C4101:
'exception': unreferenced local variable
```
I'll try switching off unity builds next...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
