ianmcook commented on a change in pull request #9553:
URL: https://github.com/apache/arrow/pull/9553#discussion_r583229104
##########
File path: cpp/CMakeLists.txt
##########
@@ -58,6 +58,12 @@ endif()
string(TOLOWER ${CMAKE_BUILD_TYPE} LOWERCASE_BUILD_TYPE)
string(TOUPPER ${CMAKE_BUILD_TYPE} UPPERCASE_BUILD_TYPE)
+# this must be included before the project() command, because of the way
+# vcpkg (ab)uses CMAKE_TOOLCHAIN_FILE to inject its logic into CMake
+if(ARROW_DEPENDENCY_SOURCE STREQUAL "VCPKG")
+ include("${CMAKE_CURRENT_SOURCE_DIR}/cmake_modules/Findvcpkg.cmake")
Review comment:
The patch seems to work fine 👍
I changed the name to `Usevcpkg.cmake`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
