jorisvandenbossche commented on code in PR #42118: URL: https://github.com/apache/arrow/pull/42118#discussion_r1636595894
########## cpp/src/arrow/c/dlpack.h: ########## @@ -48,4 +51,7 @@ Result<DLManagedTensor*> ExportArray(const std::shared_ptr<Array>& arr); ARROW_EXPORT Result<DLDevice> ExportDevice(const std::shared_ptr<Array>& arr); +ARROW_EXPORT +Result<DLDevice> ExportTensorDevice(const std::shared_ptr<Tensor>& t); Review Comment: For the C++ side, it might be more natural API to call this `ExportDevice` as well (so just add an additional supported signature for the existing function) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
