felipecrv commented on code in PR #41956:
URL: https://github.com/apache/arrow/pull/41956#discussion_r1637306320
##########
cpp/src/arrow/array/array_nested.cc:
##########
@@ -836,7 +836,7 @@ Result<std::shared_ptr<Array>> MapArray::FromArraysInternal(
return Status::NotImplemented("Null bitmap with offsets slice not
supported.");
}
- if (offsets->null_count() > 0) {
+ if (offsets->data()->MayHaveNulls()) {
Review Comment:
There is a similar condition above `keys->null_count() != 0` that should be
`keys->MayHaveNulls()` as well. I think you've changed this in the other PR (?)
so a rebase here would do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
