ZhangHuiGui commented on code in PR #41975:
URL: https://github.com/apache/arrow/pull/41975#discussion_r1637465370
##########
cpp/src/arrow/compute/exec.cc:
##########
@@ -1022,25 +1048,7 @@ Status CheckCanExecuteChunked(const VectorKernel*
kernel) {
class VectorExecutor : public KernelExecutorImpl<VectorKernel> {
public:
Status Execute(const ExecBatch& batch, ExecListener* listener) override {
- // Some vector kernels have a separate code path for handling
- // chunked arrays (VectorKernel::exec_chunked) so we check if we
- // have any chunked arrays. If we do and an exec_chunked function
- // is defined then we call that.
- bool have_chunked_arrays = false;
- for (const Datum& arg : batch.values) {
- if (arg.is_chunked_array()) have_chunked_arrays = true;
- }
-
- output_num_buffers_ =
static_cast<int>(output_type_.type->layout().buffers.size());
-
- // Decide if we need to preallocate memory for this kernel
- validity_preallocated_ =
Review Comment:
Thanks for the reminder, I will take a look.
Current PR just optimize the execution logic of chunked-array from the NULL
pre-allocation part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
