jorisvandenbossche commented on code in PR #42098:
URL: https://github.com/apache/arrow/pull/42098#discussion_r1637665634


##########
python/pyarrow/tests/test_ipc.py:
##########
@@ -1272,6 +1273,15 @@ def test_record_batch_reader_cast():
     with pytest.raises(pa.lib.ArrowTypeError, match='Field 0 cannot be cast'):
         reader.cast(pa.schema([pa.field('a', pa.list_(pa.int32()))]))
 
+    # Cast to same type should always work also for date32
+    # (https://github.com/apache/arrow/issues/41884)

Review Comment:
   It's not broken for most pairs of equal types, only for a small subset (most 
types have a  T->T cast function). But the comment is indeed too specific about 
datte32, will update



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to