alamb commented on PR #5871: URL: https://github.com/apache/arrow-rs/pull/5871#issuecomment-2165422279
The bechmark I ran suggests this kernel is almost 2x as fast as the existing approach (which makes sense as it avoids a copy). Nice work @XiangpengHao ``` ++ critcmp master view-to-dict group master view-to-dict ----- ------ ------------ cast dict to string view 1.79 123.2±1.68µs ? ?/sec 1.00 68.8±2.76µs ? ?/sec cast string view to dict 1.00 249.9±0.68µs ? ?/sec 1.07 268.3±0.53µs ? ?/sec ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
