pitrou commented on code in PR #42122:
URL: https://github.com/apache/arrow/pull/42122#discussion_r1638129720
##########
cpp/src/arrow/telemetry/telemetry_test.cc:
##########
@@ -78,6 +81,10 @@ void Log(LogLevel severity, std::string_view message) {
class TestLogging : public ::testing::Test {
public:
void SetUp() override {
+ auto env_var = arrow::internal::GetEnvVar(kLoggingEnvVar);
+ if (env_var.status().IsKeyError()) {
+ GTEST_SKIP() << "Env var " << kLoggingEnvVar << " is undefined";
+ }
Review Comment:
If these tests need an env var to be set, can it be set 1) either in the
test setup (if not too late) 2) or in `ci/scripts/cpp_test.sh`? It would be
better than skipping this test on many different CI configurations.
(it would probably be better if the tests could be made independent of the
environment, btw, but I realize that may be difficult depending on
implementation specifics)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
