felipecrv commented on code in PR #42106:
URL: https://github.com/apache/arrow/pull/42106#discussion_r1638335594
##########
cpp/src/arrow/compute/exec.cc:
##########
@@ -1345,20 +1345,41 @@ const CpuInfo* ExecContext::cpu_info() const { return
CpuInfo::GetInstance(); }
SelectionVector::SelectionVector(std::shared_ptr<ArrayData> data)
: data_(std::move(data)) {
- DCHECK_EQ(Type::INT32, data_->type->id());
+ DCHECK_EQ(Type::BOOL, data_->type->id());
Review Comment:
Bitmaps are alternatives to selection-vectors, yes, but they have a
disadvantage: they don't reduce in size as you process them — you start with
`length` bits and end up with `length` bits and have to scan them over and
over. Ideally we should have both forms and use bitmaps when the selection is
small, but if we are going to simplify things and have a single form it should
be selection vectors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
