bkietz commented on a change in pull request #9577:
URL: https://github.com/apache/arrow/pull/9577#discussion_r583796554
##########
File path: cpp/src/arrow/compute/kernels/vector_sort.cc
##########
@@ -70,7 +74,7 @@ struct ResolvedChunk {
bool IsNull() const { return array->IsNull(index); }
- ViewType GetView() const { return array->GetView(index); }
+ LogicalValueType Value() const { return
V::LogicalValue(array->GetView(index)); }
Review comment:
We need to refactor/rename `GetViewType`, this was very confusing to
read (not in any way that's your fault)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
