raulcd commented on code in PR #527:
URL: https://github.com/apache/arrow-nanoarrow/pull/527#discussion_r1639995424
##########
src/nanoarrow/nanoarrow_device_metal_test.cc:
##########
@@ -237,15 +246,25 @@ TEST_P(StringTypeParameterizedTestFixture,
ArrowDeviceMetalArrayViewString) {
EXPECT_EQ(device_array_view.array_view.buffer_views[2].size_bytes, 7);
- // We should be able to move arrays to Metal (this may depend on MacOS
version
- // ...wrapping an arbitrary sequence of bytes as an MTL::Buffer failed under
- // previous versions of MacOS but now seems to work)
+ // In some MacOS environments, ArrowDeviceArrayMoveToDevice() with buffers
allocated
+ // using ArrowMalloc() will work (i.e., apparently MTL::Buffer can wrap
+ // arbitrary bytes, but only sometimes)
Review Comment:
is this depending on macOS version or just randomly on the same version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
