jorisvandenbossche commented on code in PR #37822:
URL: https://github.com/apache/arrow/pull/37822#discussion_r1640047599
##########
python/pyarrow/tests/test_compute.py:
##########
@@ -2481,6 +2493,10 @@ def _check_temporal_rounding(ts, values, unit):
@pytest.mark.skipif(sys.platform == "win32" and not util.windows_has_tzdata(),
reason="Timezone database is not installed on Windows")
[email protected](
+ sys.platform == "emscripten",
+ reason="Emscripten datetime is implemented in Javascript and works
differently"
+)
Review Comment:
> because we get our timezone files using the python tzdata package, which
builds using the -b slim option, which is not supported yet by
HowardHinnant/date
It's still a bit bizarre.
I checked locally on my Linux in a conda env, and the zoneinfo files
provided in `/env/share/zoneinfo` ("system" provided) or
`env/lib/python3.11/site-packages/tzdata/zoneinfo` (so from tzdata package) are
exactly the same. So if `tzdata` provides the slim binaries, I don't understand
how this is working ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
