paleolimbot opened a new pull request, #528: URL: https://github.com/apache/arrow-nanoarrow/pull/528
In https://github.com/apache/arrow-nanoarrow/pull/404, the `_v` literal was added, making it much more compact to define an `ArrowStringView` and compare its equality to something else. This PR refactors tests that used `EXPECT/ASSERT_EQ()` to be more compact, and replaces `ArrowCharView()` with the string literal. From reading https://en.cppreference.com/w/cpp/string/basic_string_view/operator%22%22sv and https://json.nlohmann.me/api/macros/json_use_global_udls/#notes it seems like constraining the user-defined literal is the "modern" way to do this...I am not sure that `"_sv"` is the best choice (maybe too close to `"sv"`?), but it did seem more descriptive than `"_v` for those reading the tests without knowing that these literals are defined. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
