alamb commented on code in PR #5888:
URL: https://github.com/apache/arrow-rs/pull/5888#discussion_r1640439193
##########
object_store/src/aws/credential.rs:
##########
@@ -424,9 +424,6 @@ fn canonicalize_headers(header_map: &HeaderMap) -> (String,
String) {
///
<https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/configuring-instance-metadata-service.html>
#[derive(Debug)]
pub struct InstanceCredentialProvider {
- // https://github.com/apache/arrow-rs/issues/5884
- #[allow(dead_code)]
Review Comment:
gah! it would be nice if we followed the pattern to mark all such structs
`pub(crate)` so it is clearer from the definition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
