felipecrv commented on code in PR #41700:
URL: https://github.com/apache/arrow/pull/41700#discussion_r1641239721
##########
cpp/src/arrow/compute/kernels/vector_selection_internal.cc:
##########
@@ -60,6 +60,7 @@ void RegisterSelectionFunction(const std::string& name,
FunctionDoc doc,
{std::move(kernel_data.value_type),
std::move(kernel_data.selection_type)},
OutputType(FirstType));
base_kernel.exec = kernel_data.exec;
+ base_kernel.exec_chunked = kernel_data.chunked_exec;
Review Comment:
The member variable is called `exec_chunked` but the type is called
`ChunkedExec` (so confusing). In this PR I ended up sticking to `chunked_exec`.
Once everything is reviewed and merged I could try to unify things to the
direction people prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
