llama90 commented on code in PR #42161: URL: https://github.com/apache/arrow/pull/42161#discussion_r1641918672
########## java/memory/memory-core/src/test/java/org/apache/arrow/memory/TestAccountant.java: ########## @@ -16,10 +16,11 @@ */ package org.apache.arrow.memory; -import static org.junit.Assert.assertEquals; +import org.junit.jupiter.api.Test; -import org.junit.Assert; -import org.junit.Test; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.fail; Review Comment: Good point. I also noticed that the accessor is ambiguous. However, the main goal of these PRs is to change the JUnit version from 4 to 5, so I did not modify the accessor to maintain consistency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
