kou commented on code in PR #42131:
URL: https://github.com/apache/arrow/pull/42131#discussion_r1641980742
##########
.github/workflows/ruby.yml:
##########
@@ -364,7 +366,8 @@ jobs:
- name: Install vcpkg
shell: bash
run: |
- ci/scripts/install_vcpkg.sh "${VCPKG_ROOT}"
+ # Install a more recent vcpkg than what's in .env, as we need recent
fixes to the gobject-introspection port
+ ci/scripts/install_vcpkg.sh "${VCPKG_ROOT}" 2024.04.26
"$(pwd)/ci/vcpkg/ports-2024.04.26.patch"
Review Comment:
Yes.
Could you split this to a separated PR because wheel/jar builds also depend
on vcpkg.
##########
.github/workflows/ruby.yml:
##########
@@ -364,7 +366,8 @@ jobs:
- name: Install vcpkg
shell: bash
run: |
- ci/scripts/install_vcpkg.sh "${VCPKG_ROOT}"
+ # Install a more recent vcpkg than what's in .env, as we need recent
fixes to the gobject-introspection port
+ ci/scripts/install_vcpkg.sh "${VCPKG_ROOT}" 2024.04.26
"$(pwd)/ci/vcpkg/ports-2024.04.26.patch"
Review Comment:
Yes.
Could you split this to a separated PR because wheel/jar builds also depend
on vcpkg?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
