jinchengchenghh commented on code in PR #41646:
URL: https://github.com/apache/arrow/pull/41646#discussion_r1642107792
##########
cpp/src/arrow/engine/substrait/serde.h:
##########
@@ -183,6 +184,13 @@ ARROW_ENGINE_EXPORT Result<BoundExpressions>
DeserializeExpressions(
const ConversionOptions& conversion_options = {},
ExtensionSet* ext_set_out = NULLPTR);
+/// \brief Deserialize a Substrait Literal message to the map
+///
+/// \param[in] buf a buffer containing the protobuf serialization of a
Substrait Literal
+/// \param[out] out deserialize to this map.
+ARROW_ENGINE_EXPORT Status
+DeserializeMap(const Buffer& buf, std::unordered_map<std::string,
std::string>& out);
Review Comment:
I try to move it, but meet this exception, can you give me some clue?
```
[ 83%] Building CXX object
dataset/CMakeFiles/arrow_java_jni_dataset.dir/src/main/cpp/jni_util.cc.o
/mnt/DP_disk1/code/arrow/java/dataset/src/main/cpp/jni_wrapper.cc:42:10:
fatal error: substrait/algebra.pb.h: No such file or directory
42 | #include "substrait/algebra.pb.h" // IWYU pragma: export
| ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
