bkietz commented on a change in pull request #9532:
URL: https://github.com/apache/arrow/pull/9532#discussion_r583924716
##########
File path: cpp/src/arrow/dataset/scanner.cc
##########
@@ -33,21 +34,10 @@
namespace arrow {
namespace dataset {
-ScanOptions::ScanOptions(std::shared_ptr<Schema> schema)
- : projector(RecordBatchProjector(std::move(schema))) {}
-
-std::shared_ptr<ScanOptions> ScanOptions::ReplaceSchema(
- std::shared_ptr<Schema> schema) const {
- auto copy = ScanOptions::Make(std::move(schema));
- copy->filter = filter;
- copy->batch_size = batch_size;
- return copy;
-}
-
std::vector<std::string> ScanOptions::MaterializedFields() const {
Review comment:
Correct, `FieldsInExpression(projection)` will yield only materialized
fields. That SQL's not supported; only fields in the dataset schema may be
referenced
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
