alamb commented on code in PR #5895:
URL: https://github.com/apache/arrow-rs/pull/5895#discussion_r1643385628
##########
arrow-buffer/src/buffer/immutable.rs:
##########
@@ -71,6 +71,24 @@ impl Buffer {
}
}
+ /// Returns the offset, in bytes, of `Self::ptr` to `Self::data`
Review Comment:
👍
##########
arrow-data/src/ffi.rs:
##########
@@ -131,6 +131,43 @@ impl FFI_ArrowArray {
data.buffers().iter().map(|b| Some(b.clone())).collect()
};
+ // Handle buffer offset for offset buffer.
+ let offset_offset = match data.data_type() {
+ DataType::Utf8 | DataType::Binary => {
+ // Offset buffer is possible a slice of the buffer.
Review Comment:
I think this looks much nicer now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
