emkornfield commented on code in PR #41765:
URL: https://github.com/apache/arrow/pull/41765#discussion_r1643718103
##########
cpp/src/parquet/types.cc:
##########
@@ -464,7 +464,10 @@ std::shared_ptr<const LogicalType> LogicalType::FromThrift(
} else if (type.__isset.FLOAT16) {
return Float16LogicalType::Make();
} else {
- throw ParquetException("Metadata contains Thrift LogicalType that is not
recognized");
+ // Or provide some mechanism to optionally error here?
Review Comment:
> I still have to figure out how to write a full-on file so that this is
tested properly! (I figured out how to test the schema conversion but not how
to check a full-on file yet).
Probably hacking the generated thrift code with a very high field ID and
writing out the file and then trying to read it back in could work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
