alamb commented on a change in pull request #9571:
URL: https://github.com/apache/arrow/pull/9571#discussion_r583950068
##########
File path: rust/arrow/src/compute/kernels/cast.rs
##########
@@ -1719,20 +1791,27 @@ mod tests {
#[test]
fn test_cast_string_to_timestamp() {
- let a = StringArray::from(vec![
Review comment:
I recommend adding coverage here to convert from `LargeUtf8` string
arrays as well - I don't think they are covered by these tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
