nealrichardson commented on code in PR #42210:
URL: https://github.com/apache/arrow/pull/42210#discussion_r1647512602
##########
r/tools/nixlibs.R:
##########
@@ -814,8 +816,14 @@ set_thirdparty_urls <- function(env_var_list) {
env_var_list
}
-is_feature_requested <- function(env_varname, default =
env_is("LIBARROW_MINIMAL", "false")) {
- env_value <- tolower(Sys.getenv(env_varname))
+is_feature_requested <- function(env_varname, env_var_list, default =
env_is("LIBARROW_MINIMAL", "false")) {
+ # look in our env_var_list first, if it's not found there go to
+ # the actual environment
+ env_value <- tolower(env_var_list[[env_varname]])
+ if (is.null(env_value)) {
+ env_value <- tolower(Sys.getenv(env_varname))
+ }
Review Comment:
See, this is why passive voice is bad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
