kou commented on code in PR #42250:
URL: https://github.com/apache/arrow/pull/42250#discussion_r1649794745
##########
cpp/thirdparty/versions.txt:
##########
@@ -144,7 +146,7 @@ DEPENDENCIES=(
"ARROW_BOOST_URL boost-${ARROW_BOOST_BUILD_VERSION}.tar.gz
https://apache.jfrog.io/artifactory/arrow/thirdparty/7.0.0/boost_${ARROW_BOOST_BUILD_VERSION//./_}.tar.gz";
"ARROW_BROTLI_URL brotli-${ARROW_BROTLI_BUILD_VERSION}.tar.gz
https://github.com/google/brotli/archive/${ARROW_BROTLI_BUILD_VERSION}.tar.gz";
"ARROW_BZIP2_URL bzip2-${ARROW_BZIP2_BUILD_VERSION}.tar.gz
https://sourceware.org/pub/bzip2/bzip2-${ARROW_BZIP2_BUILD_VERSION}.tar.gz";
- "ARROW_CARES_URL cares-${ARROW_CARES_BUILD_VERSION}.tar.gz
https://c-ares.haxx.se/download/c-ares-${ARROW_CARES_BUILD_VERSION}.tar.gz";
+ "ARROW_CARES_URL cares-${ARROW_CARES_BUILD_VERSION}.tar.gz
https://github.com/c-ares/c-ares/releases/download/cares-${ARROW_CARES_BUILD_VERSION_UNDERSCORES}/c-ares-${ARROW_CARES_BUILD_VERSION}.tar.gz";
Review Comment:
How about using `${...//PATTERN/REPLACED}` bash feature instead of defining
`..._UNDERSCORES` like `ARROW_BOOST_BUILD_VERSION` did?
(This data is used by only `download_dependencies.sh`.)
```suggestion
"ARROW_CARES_URL cares-${ARROW_CARES_BUILD_VERSION}.tar.gz
https://github.com/c-ares/c-ares/releases/download/cares-${ARROW_CARES_BUILD_VERSION//./_}/c-ares-${ARROW_CARES_BUILD_VERSION}.tar.gz";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
