tustvold commented on code in PR #5922:
URL: https://github.com/apache/arrow-rs/pull/5922#discussion_r1650031226
##########
arrow-array/src/array/byte_view_array.rs:
##########
@@ -330,6 +343,78 @@ impl<T: ByteViewType + ?Sized> GenericByteViewArray<T> {
builder.finish()
}
+
+ /// Comparing two [`GenericByteViewArray`] at index `left_idx` and
`right_idx`
Review Comment:
I would prefer that comparison functionality lives in arrow-ord unless there
is a compelling reason it needs to live in arrow-array, this avoids bloating
the fundamental dependencies and is more consistent with the general crate
topology
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
