XiangpengHao commented on code in PR #5931:
URL: https://github.com/apache/arrow-rs/pull/5931#discussion_r1650352121
##########
arrow-string/src/predicate.rs:
##########
@@ -95,11 +95,10 @@ impl<'a> Predicate<'a> {
///
/// If `negate` is true the result of the predicate will be negated
#[inline(never)]
- pub fn evaluate_array<O: OffsetSizeTrait>(
- &self,
- array: &GenericStringArray<O>,
- negate: bool,
- ) -> BooleanArray {
+ pub fn evaluate_array<'i, T>(&self, array: T, negate: bool) -> BooleanArray
Review Comment:
That could work.
I think this pr is to give a reasonable baseline for string view
implementation and unblock the string view for DF. And if we care enough later,
we do need to copy-paste a lot of the code and make specialized comparsion for
StringViewArray.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
