bkief commented on code in PR #42169:
URL: https://github.com/apache/arrow/pull/42169#discussion_r1653316003
##########
python/pyarrow/_parquet.pyx:
##########
@@ -1941,6 +1943,14 @@ cdef shared_ptr[WriterProperties]
_create_writer_properties(
"'use_byte_stream_split' cannot be passed"
"together with 'column_encoding'")
+ # store_decimal_as_integer
+
+ if isinstance(store_decimal_as_integer, bool):
Review Comment:
At present, I believe the C++ method does not accept columns.
##########
python/pyarrow/_dataset_parquet.pyx:
##########
@@ -613,6 +613,9 @@ cdef class ParquetFileWriteOptions(FileWriteOptions):
write_page_index=self._properties["write_page_index"],
write_page_checksum=self._properties["write_page_checksum"],
sorting_columns=self._properties["sorting_columns"],
+ store_decimal_as_integer=(
Review Comment:
I didn't see any of the file writer options tested in test_dataset.py so I
did not add anything specific for the dataset writer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
