raulcd commented on code in PR #41904:
URL: https://github.com/apache/arrow/pull/41904#discussion_r1654694864
##########
docker-compose.yml:
##########
@@ -1221,6 +1222,50 @@ services:
volumes: *conda-volumes
command: *python-conda-command
+ conda-python-no-numpy:
+ # Usage:
+ # docker-compose build conda
+ # docker-compose build conda-cpp
+ # docker-compose build conda-python
+ # docker-compose build conda-python-no-numpy
+ # docker-compose run --rm conda-python-no-numpy
+ image: ${REPO}:${ARCH}-conda-python-${PYTHON}-no-numpy
+ build:
+ context: .
+ dockerfile: ci/docker/conda-python-pandas.dockerfile
+ cache_from:
+ - ${REPO}:${ARCH}-conda-python-${PYTHON}-pandas-${PANDAS}
+ args:
+ repo: ${REPO}
+ arch: ${ARCH}
+ python: ${PYTHON}
+ numpy: ${NUMPY}
+ pandas: ${PANDAS}
+ shm_size: *shm-size
+ environment:
+ <<: [*common, *ccache, *sccache]
+ PARQUET_REQUIRE_ENCRYPTION: # inherit
+ # The without numpy mark is only used to select tests to be run
+ # when numpy is not installed but those tests will also run
+ # if numpy is present.
Review Comment:
Based on @jorisvandenbossche comments there are concerns of having to mark
all tests that currently require numpy with the `numpy` mark, see:
https://github.com/apache/arrow/pull/41904#pullrequestreview-2101477276
Those are a lot and the suggesting was to mark a small subset to cover basic
functionality to validate we can create arrays / use compute / datasets without
numpy and to run those as part of this PR.
That's what the `pytest.mark.without_numpy` mark does.
The `pytest.mark.numpy` and `pytest.mark.nonumpy` provide the same
functionality for numpy as the `pytest.mark.pandas` and `pytest.mark.nopandas`
for pandas.
I agree that the name `without_numpy` isn't probably the best one but
couldn't come up with something better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
