joemarshall commented on code in PR #37822: URL: https://github.com/apache/arrow/pull/37822#discussion_r1657089378
########## ci/docker/conda-python-emscripten.dockerfile: ########## @@ -0,0 +1,67 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +ARG repo +ARG arch +ARG python="3.12" +FROM ${repo}:${arch}-conda-python-${python} + +ARG selenium_version="4.15.2" +ARG pyodide_version="0.26.0" +ARG emscripten_version="3.1.58" +ARG chrome_version="latest" +ARG required_python_min="(3,12)" +# fail if python version < 3.12 +RUN echo "check PYTHON>=${required_python_min}" && python -c "import sys;sys.exit(0 if sys.version_info>=${required_python_min} else 1)" + +# install selenium and pyodide-build and recent python + +# needs to be a login shell so ~/.profile is read +SHELL ["/bin/bash", "--login", "-c", "-o", "pipefail"] + +RUN python -m pip install --no-cache-dir selenium==${selenium_version} &&\ + python -m pip install --no-cache-dir --upgrade --pre pyodide-build==${pyodide_version} + +COPY ci/scripts/install_emscripten.sh /arrow/ci/scripts/ +RUN bash /arrow/ci/scripts/install_emscripten.sh ~ "${emscripten_version}" + +# make sure zlib is cached in the EMSDK folder +RUN source ~/emsdk/emsdk_env.sh && embuilder --pic build zlib + +# install pyodide dist directory to /pyodide +WORKDIR / +RUN pyodide_dist_url="https://github.com/pyodide/pyodide/releases/download/${pyodide_version}/pyodide-${pyodide_version}.tar.bz2"; && \ + wget --progress=dot:giga "${pyodide_dist_url}" -O- |tar -xj + +# install chrome for testing browser based runner +# zip needed for chrome, libpthread stubs installs pthread module to cmake, build-essential makes +# sure that unix make is available in isolated python environments + +# Install basic build stuff, don't pin versions, hence ignore lint +# hadolint ignore=DL3008 +RUN apt-get update && apt-get install --no-install-recommends -y -q unzip zip libpthread-stubs0-dev build-essential && \ + apt-get clean && \ + rm -rf /var/lib/apt/lists/* + +COPY ci/scripts/install_chromedriver.sh /arrow/ci/scripts/ +RUN /arrow/ci/scripts/install_chromedriver.sh "${chrome_version}" Review Comment: nope, comment out above was a mistake sorry ########## ci/docker/conda-python-emscripten.dockerfile: ########## @@ -0,0 +1,67 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +ARG repo +ARG arch +ARG python="3.12" +FROM ${repo}:${arch}-conda-python-${python} + +ARG selenium_version="4.15.2" +ARG pyodide_version="0.26.0" +ARG emscripten_version="3.1.58" +ARG chrome_version="latest" +ARG required_python_min="(3,12)" +# fail if python version < 3.12 +RUN echo "check PYTHON>=${required_python_min}" && python -c "import sys;sys.exit(0 if sys.version_info>=${required_python_min} else 1)" + +# install selenium and pyodide-build and recent python + +# needs to be a login shell so ~/.profile is read +SHELL ["/bin/bash", "--login", "-c", "-o", "pipefail"] + +RUN python -m pip install --no-cache-dir selenium==${selenium_version} &&\ Review Comment: as above, sorry -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
