gforsyth commented on code in PR #43073:
URL: https://github.com/apache/arrow/pull/43073#discussion_r1659395288
##########
python/pyarrow/_dataset.pyx:
##########
@@ -953,7 +953,7 @@ cdef class InMemoryDataset(Dataset):
----------
source : RecordBatch, Table, list, tuple
The data for this dataset. Can be a RecordBatch, Table, list of
- RecordBatch/Table, iterable of RecordBatch, or a RecordBatchReader
+ RecordBatch/Table, or an iterable of RecordBatch
Review Comment:
That is also my read of a `RecordBatchReader`, but this code path suggest
that a list or tuple of batches would work:
```
if isinstance(source, (list, tuple)):
batches = []
for item in source:
if isinstance(item, pa.RecordBatch):
batches.append(item)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
