nevi-me commented on a change in pull request #9573:
URL: https://github.com/apache/arrow/pull/9573#discussion_r584147360



##########
File path: rust/rfcs/LICENSE-APACHE
##########
@@ -0,0 +1,201 @@
+                              Apache License

Review comment:
       Do we need a license if the `rfcs` folder will live in this repo?

##########
File path: rust/rfcs/0000-template.md
##########
@@ -0,0 +1,27 @@
+- Feature Name: (fill me in with a unique ident, `my_awesome_feature`)
+- Start Date: (fill me in with today's date, YYYY-MM-DD)
+- RFC PR: [arrow/rfcs#0000](https://github.com/apache/arrow/pull/0000)
+- Rust Issue: [arrow/rust#0000](https://github.com/apache/arrow/issues/0000)
+
+# Summary
+[summary]: #summary
+
+One paragraph explanation of the feature.
+
+# Motivation
+[motivation]: #motivation
+
+Why are we doing this? 
+What use cases does it support?
+What is the expected outcome?
+
+# Proposed changes
+[proposed-changes]: #proposed-changes
+
+Explain the proposed changes and how they can be implemented
+
+# Expected advantages
+[expected advantages]: #expected-advantages
+
+Write down a small description of the expected advantages from the proposed
+changes

Review comment:
       We can include **Breaking Changes**, perhaps as a subsection of 
**Proposed Changes**

##########
File path: rust/rfcs/0000-template.md
##########
@@ -0,0 +1,27 @@
+- Feature Name: (fill me in with a unique ident, `my_awesome_feature`)

Review comment:
       This needs the ASF header




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to